Re: [libvirt] [PATCH 11/15] NEWS: Fix newlines
On Wed, Oct 14, 2015 at 05:06:47PM +0200, Andrea Bolognani wrote:
On Wed, 2015-10-14 at 15:09 +0200, Martin Kletzander wrote:
> On Wed, Oct 14, 2015 at 10:36:07AM +0200, Andrea Bolognani wrote:
> > Some <br/> tags were missing from the end of the corresponding
> > line, some of there were in the middle of the line instead.
> > ---
> > docs/news.html.in | 199 +++++++++++++++++++++++++++----------------
> > -----------
> > 1 file changed, 99 insertions(+), 100 deletions(-)
> >
>
> This one got me thinking. Can't we get rid of all those line breaks
> and add them in the XSLT? That'd be great. Mainly those that are
> being fixed in the first hunk, I don't care either way about those in
> the second hunk (although they would follow the same rule anyways.
Not sure I'm following you... We can of course add
newlines to the plain text NEWS file using the XSLT
stylesheet, but we still need the <br/> tags for
the newlines to appear in the HTML version...
Well, news.html.in is transformed into news.html by site.xsl (iirc),
and I was wondering whether we can add <br/> for each one of these
newlines. Maybe with different xsl file. But now I'm thinking what
if we translate simple news file into news.html.in and that way we
don't need to deal with any of these, even DV would have it easier
when creating new release. Anyway, that's just a hint.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)