Re: [libvirt] [dbus RFC 11/11] main: add support for all libvirt drivers

On Mon, Jan 22, 2018 at 06:16:09PM +0100, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/main.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/src/main.c b/src/main.c > index 14c7c18..6421919 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -85,13 +85,31 @@ struct virtDBusDriver { > }; > > static const struct virtDBusDriver sessionDrivers[] = { > - { "qemu:///session", "/org/libvirt/qemu" }, > - { "test:///default", "/org/libvirt/test" }, > + { "qemu:///session", "/org/libvirt/qemu" }, > + { "test:///default", "/org/libvirt/test" }, > + { "uml:///session", "/org/libvirt/uml" }, > + { "vbox:///session", "/org/libvirt/vbox" }, > + { "vmwarefusion:///session", "/org/libvirt/vmwarefusion" }, > + { "vmwareplayer:///session", "/org/libvirt/vmwareplayer" }, > + { "vmwarews:///session", "/org/libvirt/vmwarews" }, > }; > > static const struct virtDBusDriver systemDrivers[] = { > - { "qemu:///system", "/org/libvirt/qemu" }, > - { "test:///default", "/org/libvirt/test" }, > + { "XenApi://localhost/", "/org/libvirt/XenApi" }, Hmm, lowercase 'xenapi' would match all other paths, but uppercase matches the URI scheme.

> + { "bhyve:///system", "/org/libvirt/bhyve" }, > + { "esx://localhost/", "/org/libvirt/esx" }, Not sure this is useful, as I don't think there's any practical way to manage ESX from the host it runs on, as that would imply being able to run custom software inside ESX. > + { "gsx://localhost/", "/org/libvirt/gsx" }, > + { "hyperv://localhost/", "/org/libvirt/hyperv" }, I don't think this is useful either. > + { "lxc:///", "/org/libvirt/lxc" }, > + { "openvz:///system", "/org/libvirt/openvz" }, > + { "phyp://localhost/", "/org/libvirt/phyp" }, IIUC, phyp is also always a remotely executing driver, which needs to ssh into the hypervisor. > + { "qemu:///system", "/org/libvirt/qemu" }, > + { "test:///default", "/org/libvirt/test" }, > + { "uml:///system", "/org/libvirt/uml" }, > + { "vbox:///system", "/org/libvirt/vbox" }, > + { "vpx://localhost/", "/org/libvirt/vpx" }, Same as ESX - remote only.