+1.

libvirt-cim-bounces@redhat.com wrote on 2009-03-25 10:16:07:

> # HG changeset patch
> # User Kaitlin Rupert <karupert@us.ibm.com>
> # Date 1237947348 25200
> # Node ID 8a672626eb00a400605fd468cc225d2713bd9872
> # Parent  57f08f1c7a1a8b7c9068e1bf0e76368bb92ead26
> [TEST] Remove create_using_definesystem()
>
> It's no longer being used.
>
> Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com>
>
> diff -r 57f08f1c7a1a -r 8a672626eb00 suites/libvirt-
> cim/lib/XenKvmLib/common_util.py
> --- a/suites/libvirt-cim/lib/XenKvmLib/common_util.py   Sun Mar 22
> 22:39:16 2009 -0700
> +++ b/suites/libvirt-cim/lib/XenKvmLib/common_util.py   Tue Mar 24
> 19:15:48 2009 -0700
> @@ -71,64 +71,6 @@
>  
>      return (0, cs)
>  
> -def create_using_definesystem(domain_name, ip, params=None, ref_config=' ',
> -                              exp_err=None, virt='Xen'):
> -    bug = "85673"
> -    try:
> -        class_vsms = eval('vsms.' + \
> -                get_typed_class(virt, 'VirtualSystemManagementService'))
> -        service = class_vsms(ip)
> -
> -        if params == None or len(params) == 0:
> -            vssd, rasd = vsms.default_vssd_rasd_str(
> -                            dom_name=domain_name, virt=virt)
> -        else:
> -            vssd = params['vssd']
> -            rasd = params['rasd']
> -
> -        if exp_err == None or len(exp_err) == 0:
> -            exp_rc = 0
> -            exp_desc = ''
> -
> -        else:
> -            exp_rc = exp_err['exp_rc']
> -            exp_desc = exp_err['exp_desc']
> -
> -        service.DefineSystem(SystemSettings=vssd,
> -                             ResourceSettings=rasd,
> -                             ReferenceConfiguration=ref_config)
> -    except pywbem.CIMError, (rc, desc):
> -        if rc == exp_rc and desc.find(exp_desc) >= 0:
> -            logger.info('Got expected rc code and error string.')
> -            if exp_err != None:
> -                return PASS
> -            return FAIL
> -
> -        logger.error('Unexpected rc code %s and description:\n %s',rc, desc)
> -        return FAIL
> -
> -    except Exception, details:
> -        logger.error('Error invoke method `DefineSystem\'.  %s', details)
> -        return FAIL
> -
> -    if exp_err != None:    
> -        logger.error('DefineSystem should NOT return OK with invalid arg')
> -        undefine_test_domain(dname, options.ip, virt=virt)
> -        return XFAIL_RC(bug)
> -
> -    set_uuid(viruuid(domain_name, ip, virt=virt))
> -    myxml = dumpxml(domain_name, ip, virt=virt)
> -
> -    name = xml_get_dom_name(myxml)
> -
> -    if name != domain_name:
> -        logger.error ("Name should be '%s' instead of '%s'",
> -                      domain_name, name)
> -        undefine_test_domain(name, ip, virt=virt)
> -        return FAIL
> -
> -    return PASS
> -
>  def verify_err_desc(exp_rc, exp_desc, err_no, err_desc):
>      if err_no == exp_rc and err_desc.find(exp_desc) >= 0:
>          logger.info("Got expected exception where ")
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim@redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim