See <https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-29/234/dis... Changes: [pkrempa] qemu: blockjob: Extract emitting of libvirt events [pkrempa] qemu: blockjob: Emit VIR_DOMAIN_EVENT_ID_BLOCK_JOB only for local disks [pkrempa] qemu: processBlockJobEvent: Use qemuBlockJobUpdate to process block job [pkrempa] qemu: blockjob: Unexport qemuBlockJobEventProcess [pkrempa] qemu: blockjob: Rename public APIs [pkrempa] qemu: blockjob: Remove header dependency on qemu_domain.h [pkrempa] qemu: Consolidate disk blockjob variables into a structure [pkrempa] qemu: process: Consolidate error paths in qemuProcessHandleBlockJob [pkrempa] qemu: blockjob: Rename qemuBlockJobEventProcess to [pkrempa] qemu: blockjob: Split out handling of completed jobs [pkrempa] qemu: migration: Properly note that non-shared-storage migration uses a [pkrempa] qemu: process: refresh block jobs on reconnect [pkrempa] qemu: driver: Remove block job status reprobing from [pkrempa] qemu: migration: Simplify cancellation of migration blockjobs [pkrempa] qemu: blockjob: Turn struct qemuBlockJobData into a virObject [pkrempa] qemu: blockjob: Clarify that job 'status' field contains new state [pkrempa] qemu: migration: Separate startup of disk mirror from migration logic [pkrempa] qemu: blockjob: Add functions for block job state control [pkrempa] qemu: blockjob: Drop unnecessary calls to qemuBlockJobSyncEndDisk [pkrempa] qemu: blockjob: Add reference to disk into struct qemuBlockJobData [pkrempa] qemu: blockjob: Record job type when starting the job [pkrempa] qemu: blockjob: Pass in job to qemuBlockJobEventProcessLegacy [pkrempa] qemu: blockjob: Convert qemuBlockJobSyncBeginDisk to work with the job [pkrempa] qemu: blockjob: Track current state of blockjob [pkrempa] qemu: migration: Extract reporting of disk migration error [pkrempa] qemu: blockjob: Remove error propagation from qemuBlockJobUpdateDisk [pkrempa] qemu: blockjob: Consume new block job state in the processing function [pkrempa] qemu: blockjob: Pass job into qemuBlockJobUpdateDisk and rename it [pkrempa] qemu: Allocate diskPriv->blockjob only when there's a blockjob [pkrempa] qemu: migration: Don't call qemuBlockJobSyncEndDisk when block job has [pkrempa] qemu: blockjob: Convert qemuBlockJobSyncEndDisk to take job instead of [pkrempa] qemu: blockjob: Add job name into the data ------------------------------------------ [...truncated 146.48 KB...] CC util/libvirt_util_la-virfirmware.lo CC util/libvirt_util_la-virgettext.lo CC util/libvirt_util_la-virgic.lo CC util/libvirt_util_la-virhash.lo CC util/libvirt_util_la-virhashcode.lo CC util/libvirt_util_la-virhook.lo CC util/libvirt_util_la-virhostcpu.lo CC util/libvirt_util_la-virhostdev.lo CC util/libvirt_util_la-virhostmem.lo CC util/libvirt_util_la-viridentity.lo CC util/libvirt_util_la-virinitctl.lo CC util/libvirt_util_la-viriptables.lo CC util/libvirt_util_la-viriscsi.lo CC util/libvirt_util_la-virjson.lo CC util/libvirt_util_la-virkeycode.lo CC util/libvirt_util_la-virkeyfile.lo CC util/libvirt_util_la-virlease.lo CC util/libvirt_util_la-virlockspace.lo CC util/libvirt_util_la-virlog.lo CC util/libvirt_util_la-virmacaddr.lo CC util/libvirt_util_la-virmacmap.lo CC util/libvirt_util_la-virmodule.lo CC util/libvirt_util_la-virnetdev.lo CC util/libvirt_util_la-virnetdevbandwidth.lo CC util/libvirt_util_la-virnetdevbridge.lo CC util/libvirt_util_la-virnetdevip.lo CC util/libvirt_util_la-virnetdevmacvlan.lo CC util/libvirt_util_la-virnetdevmidonet.lo CC util/libvirt_util_la-virnetdevopenvswitch.lo CC util/libvirt_util_la-virnetdevtap.lo CC util/libvirt_util_la-virnetdevveth.lo CC util/libvirt_util_la-virnetdevvlan.lo CC util/libvirt_util_la-virnetdevvportprofile.lo CC util/libvirt_util_la-virnetlink.lo CC util/libvirt_util_la-virnodesuspend.lo CC util/libvirt_util_la-virkmod.lo CC util/libvirt_util_la-virnuma.lo CC util/libvirt_util_la-virobject.lo CC util/libvirt_util_la-virpci.lo CC util/libvirt_util_la-virpidfile.lo CC util/libvirt_util_la-virpolkit.lo CC util/libvirt_util_la-virportallocator.lo CC util/libvirt_util_la-virprocess.lo CC util/libvirt_util_la-virqemu.lo CC util/libvirt_util_la-virrandom.lo CC util/libvirt_util_la-virresctrl.lo CC util/libvirt_util_la-virrotatingfile.lo CC util/libvirt_util_la-virscsi.lo CC util/libvirt_util_la-virscsihost.lo CC util/libvirt_util_la-virscsivhost.lo CC util/libvirt_util_la-virseclabel.lo CC util/libvirt_util_la-virsecret.lo CC util/libvirt_util_la-virsexpr.lo CC util/libvirt_util_la-virsocketaddr.lo CC util/libvirt_util_la-virstorageencryption.lo CC util/libvirt_util_la-virstoragefile.lo CC util/libvirt_util_la-virstoragefilebackend.lo CC util/libvirt_util_la-virstring.lo CC util/libvirt_util_la-virsysinfo.lo CC util/libvirt_util_la-virsystemd.lo CC util/libvirt_util_la-virthread.lo CC util/libvirt_util_la-virthreadjob.lo CC util/libvirt_util_la-virthreadpool.lo CC util/libvirt_util_la-virtime.lo CC util/libvirt_util_la-virtpm.lo CC util/libvirt_util_la-virtypedparam.lo CC util/libvirt_util_la-virusb.lo CC util/libvirt_util_la-viruri.lo CC util/libvirt_util_la-virutil.lo CC util/libvirt_util_la-viruuid.lo CC util/libvirt_util_la-virvhba.lo CC util/libvirt_util_la-virvsock.lo CC util/libvirt_util_la-virxml.lo CC util/libvirt_util_la-virmdev.lo CC util/libvirt_util_la-virfilecache.lo CC conf/libvirt_conf_la-netdev_bandwidth_conf.lo CC conf/libvirt_conf_la-netdev_vport_profile_conf.lo CC conf/libvirt_conf_la-netdev_vlan_conf.lo CC conf/libvirt_conf_la-capabilities.lo CC conf/libvirt_conf_la-domain_addr.lo CC conf/libvirt_conf_la-domain_capabilities.lo CC conf/libvirt_conf_la-domain_conf.lo CC conf/libvirt_conf_la-domain_audit.lo CC conf/libvirt_conf_la-domain_nwfilter.lo CC conf/libvirt_conf_la-virsavecookie.lo CC conf/libvirt_conf_la-snapshot_conf.lo CC conf/libvirt_conf_la-numa_conf.lo CC conf/libvirt_conf_la-virdomainobjlist.lo CC conf/libvirt_conf_la-object_event.lo CC conf/libvirt_conf_la-domain_event.lo CC conf/libvirt_conf_la-network_event.lo CC conf/libvirt_conf_la-storage_event.lo CC conf/libvirt_conf_la-node_device_event.lo CC conf/libvirt_conf_la-secret_event.lo CC conf/libvirt_conf_la-network_conf.lo CC conf/libvirt_conf_la-virnetworkobj.lo CC conf/libvirt_conf_la-networkcommon_conf.lo CC conf/libvirt_conf_la-nwfilter_params.lo CC conf/libvirt_conf_la-nwfilter_ipaddrmap.lo CC conf/libvirt_conf_la-nwfilter_conf.lo CC conf/libvirt_conf_la-virnwfilterobj.lo CC conf/libvirt_conf_la-virnwfilterbindingdef.lo CC conf/libvirt_conf_la-virnwfilterbindingobj.lo CC conf/libvirt_conf_la-virnwfilterbindingobjlist.lo CC conf/libvirt_conf_la-node_device_conf.lo CC conf/libvirt_conf_la-node_device_util.lo CC conf/libvirt_conf_la-virnodedeviceobj.lo CC conf/libvirt_conf_la-storage_adapter_conf.lo CC conf/libvirt_conf_la-storage_conf.lo CC conf/libvirt_conf_la-virstorageobj.lo CC conf/libvirt_conf_la-interface_conf.lo CC conf/libvirt_conf_la-virinterfaceobj.lo CC conf/libvirt_conf_la-secret_conf.lo CC conf/libvirt_conf_la-virsecretobj.lo CC conf/libvirt_conf_la-cpu_conf.lo CC conf/libvirt_conf_la-virchrdev.lo CC conf/libvirt_conf_la-device_conf.lo CC cpu/libvirt_cpu_la-cpu.lo CC cpu/libvirt_cpu_la-cpu_x86.lo CC cpu/libvirt_cpu_la-cpu_s390.lo CC cpu/libvirt_cpu_la-cpu_arm.lo CC cpu/libvirt_cpu_la-cpu_ppc64.lo CC cpu/libvirt_cpu_la-cpu_map.lo CC security/libvirt_security_manager_la-security_driver.lo CC security/libvirt_security_manager_la-security_nop.lo CC security/libvirt_security_manager_la-security_stack.lo CC security/libvirt_security_manager_la-security_dac.lo CC security/libvirt_security_manager_la-security_manager.lo CC security/libvirt_security_manager_la-security_util.lo CC security/libvirt_security_manager_la-security_selinux.lo CC access/libvirt_driver_access_la-viraccessperm.lo CC access/libvirt_driver_access_la-viraccessmanager.lo CC access/libvirt_driver_access_la-viraccessdrivernop.lo CC access/libvirt_driver_access_la-viraccessdriverstack.lo CC access/libvirt_driver_access_la-viraccessapicheck.lo CC access/libvirt_driver_access_la-viraccessapicheckqemu.lo CC access/libvirt_driver_access_la-viraccessapichecklxc.lo CC access/libvirt_driver_access_la-viraccessdriverpolkit.lo CC rpc/libvirt_net_rpc_la-virnetmessage.lo CC rpc/libvirt_net_rpc_la-virnettlscontext.lo CC rpc/libvirt_net_rpc_la-virnetsocket.lo CC rpc/libvirt_net_rpc_la-virkeepalive.lo CC rpc/libvirt_net_rpc_la-virnetprotocol.lo CC rpc/libvirt_net_rpc_la-virkeepaliveprotocol.lo CC rpc/libvirt_net_rpc_la-virnetsshsession.lo CC rpc/libvirt_net_rpc_la-virnetsaslcontext.lo CC rpc/libvirt_net_rpc_la-virnetlibsshsession.lo CC rpc/libvirt_net_rpc_server_la-virnetserverprogram.lo CC rpc/libvirt_net_rpc_server_la-virnetserverservice.lo CC rpc/libvirt_net_rpc_server_la-virnetserverclient.lo CC rpc/libvirt_net_rpc_server_la-virnetservermdns.lo CC rpc/libvirt_net_rpc_server_la-virnetdaemon.lo CC rpc/libvirt_net_rpc_server_la-virnetserver.lo CC rpc/libvirt_net_rpc_client_la-virnetclientprogram.lo CC rpc/libvirt_net_rpc_client_la-virnetclientstream.lo CC rpc/libvirt_net_rpc_client_la-virnetclient.lo CC phyp/libvirt_driver_phyp_la-phyp_driver.lo CC test/libvirt_driver_test_la-test_driver.lo CC esx/libvirt_driver_esx_la-esx_driver.lo CC esx/libvirt_driver_esx_la-esx_interface_driver.lo CC esx/libvirt_driver_esx_la-esx_network_driver.lo CC esx/libvirt_driver_esx_la-esx_storage_driver.lo CC esx/libvirt_driver_esx_la-esx_storage_backend_vmfs.lo CC esx/libvirt_driver_esx_la-esx_storage_backend_iscsi.lo CC esx/libvirt_driver_esx_la-esx_stream.lo CC esx/libvirt_driver_esx_la-esx_util.lo CC esx/libvirt_driver_esx_la-esx_vi.lo CC esx/libvirt_driver_esx_la-esx_vi_methods.lo CC esx/libvirt_driver_esx_la-esx_vi_types.lo CC hyperv/libvirt_driver_hyperv_la-hyperv_driver.lo CC hyperv/libvirt_driver_hyperv_la-hyperv_util.lo CC hyperv/libvirt_driver_hyperv_la-hyperv_wmi.lo CC hyperv/libvirt_driver_hyperv_la-hyperv_wmi_classes.lo CC vmx/libvirt_vmx_la-vmx.lo CC vmware/libvirt_driver_vmware_la-vmware_driver.lo CC vmware/libvirt_driver_vmware_la-vmware_conf.lo CC openvz/libvirt_driver_openvz_la-openvz_conf.lo CC openvz/libvirt_driver_openvz_la-openvz_driver.lo CC openvz/libvirt_driver_openvz_la-openvz_util.lo CC xenconfig/libvirt_xenconfig_la-xen_common.lo CC xenconfig/libvirt_xenconfig_la-xen_sxpr.lo CC xenconfig/libvirt_xenconfig_la-xen_xm.lo CC secret/libvirt_secret_la-secret_util.lo CC remote/libvirt_driver_remote_la-remote_driver.lo CC remote/libvirt_driver_remote_la-remote_protocol.lo CC remote/libvirt_driver_remote_la-lxc_protocol.lo CC remote/libvirt_driver_remote_la-qemu_protocol.lo CC logging/libvirt_driver_la-log_protocol.lo CC logging/libvirt_driver_la-log_manager.lo GEN libvirt_probes.lo CC lxc/libvirt_lxc-lxc_monitor_protocol.o CC lxc/libvirt_lxc-lxc_conf.o CC lxc/libvirt_lxc-lxc_container.o CC lxc/libvirt_lxc-lxc_cgroup.o CC lxc/libvirt_lxc-lxc_domain.o CC lxc/libvirt_lxc-lxc_fuse.o CC lxc/libvirt_lxc-lxc_controller.o CC network/libvirt_leaseshelper-leaseshelper.o CC storage/libvirt_parthelper-parthelper.o CC admin/libvirt_driver_admin_la-admin_protocol.lo CC admin/libvirt_driver_admin_la-admin_server.lo CC admin/libvirt_driver_admin_la-admin_server_dispatch.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_glue.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_driver.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_snapshot_conf.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_0.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_1.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_2.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_2_20.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_3.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V4_3_4.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_0.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_1.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_V5_2.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_common.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_network.lo CC vbox/libvirt_driver_vbox_impl_la-vbox_storage.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_agent.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_alias.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_block.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_blockjob.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_capabilities.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_command.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_parse_command.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_domain.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_domain_address.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_cgroup.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_extdevice.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_hostdev.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_hotplug.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_conf.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_process.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_migration.lo CC qemu/libvirt_driver_qemu_impl_la-qemu_migration_cookie.lo ../../src/qemu/qemu_process.c: In function 'qemuProcessRefreshLegacyBlockjob': ../../src/qemu/qemu_process.c:7838:17: error: comparison between 'qemuBlockJobType' {aka 'enum <anonymous>'} and 'enum <anonymous>' [-Werror=enum-compare] if (jobtype == VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT && ^~ cc1: all warnings being treated as errors gmake[3]: *** [Makefile:11076: qemu/libvirt_driver_qemu_impl_la-qemu_process.lo] Error 1 gmake[3]: *** Waiting for unfinished jobs.... rm util/virkeycode-xtkbd.pod util/virkeycode-atset3.pod util/virkeycode-usb.pod util/virkeycode-qnum.pod util/virkeycode-win32.pod util/virkeyname-linux.pod util/virkeycode-osx.pod util/virkeycode-linux.pod util/virkeyname-osx.pod util/virkeycode-atset1.pod util/virkeyname-win32.pod util/virkeycode-atset2.pod gmake[3]: Leaving directory '<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-29/ws/build/src'> gmake[2]: *** [Makefile:7045: all] Error 2 gmake[2]: Leaving directory '<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-29/ws/build/src'> gmake[1]: *** [Makefile:2130: all-recursive] Error 1 gmake[1]: Leaving directory '<https://ci.centos.org/job/libvirt-build/systems=libvirt-fedora-29/ws/build'> gmake: *** [Makefile:2023: all] Error 2 Build step 'Execute shell' marked build as failure