[Libvirt-ci] Errored: libvirt/libvirt#1322 (master - 228ae70)

Build Update for libvirt/libvirt ------------------------------------- Build: #1322 Status: Errored Duration: 18 mins and 56 secs Commit: 228ae70 (master) Author: John Ferlan Message: qemu: Fix double free in qemuDomainSecretAESClear Commit id 02b031a4 added a secondary path from which the incoming @secinfo would not be free'd until the private data was freed in qemuDomainStorageSourcePrivateDispose. However, by doing this the original intention to free @*secinfo afterwards is lost and thus the pass by value of the secinfo->s.aes (or secinfo->s.plain for its method) results in not keeping the NULL setting in the various secret.{username|iv|ciphertext} fields upon return to qemuDomainSecretInfoClear and eventually will result in a double free at domain destroy: raise () abort () __libc_message () malloc_printerr () _int_free () virFree qemuDomainSecretAESClear qemuDomainSecretInfoClear qemuDomainSecretInfoFree qemuDomainStorageSourcePrivateDispose virObjectUnref virStorageSourceClear virStorageSourceFree virDomainDiskDefFree virDomainDefFree virDomainObjRemoveTransientDef qemuProcessStop qemuDomainDestroyFlags virDomainDestroy Signed-off-by: John Ferlan <jferlan@redhat.com> ACKed-by: Peter Krempa <pkrempa@redhat.com> View the changeset: https://github.com/libvirt/libvirt/compare/7d34949b079e...228ae70938d0 View the full build log and details: https://travis-ci.org/libvirt/libvirt/builds/388742005?utm_source=email&utm_medium=notification -- You can configure recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications This email was sent to libvirt-ci@redhat.com (mailto:libvirt-ci@redhat.com) unsubscribe from this list (http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=799582426ee249d68a954c865b9ecf84.q3yTAF39gfjNcLjHva7iXjXSQZI%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dlibvirt-ci%2540redhat.com)
participants (1)
-
Travis CI