See <https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fe... Changes: [pkrempa] storage: Properly track that backing chain members are readonly [pkrempa] qemu: domain: Format storage source node names into private data [pkrempa] util: storage: Add shadow copies of few disk properties to [pkrempa] qemu: domain: Carefuly transfer configuration from disk to storage [pkrempa] qemu: block: Extract formatting of props for 'file' backend [pkrempa] qemu: block: Handle iomode property for json 'file' driver [pkrempa] utils: storage: Mark that a virStorageSource is going to be used as a [pkrempa] qemu: Move virtual FAT disk validation from command line builder [pkrempa] qemu: block: Add support for accessing directories via the 'vvfat' [pkrempa] util: file: Use only one #ifdef for __linux__ [pkrempa] util: file: Add helper to determine whether a path is a CDROM [pkrempa] qemu: domain: Store whether a virStorageSource is a host CDROM drive [pkrempa] qemu: block: Properly handle block storage in JSON generator [pkrempa] qemu: block: Propagate 'legacy' parameter when formatting disk backing [pkrempa] qemu: block: Validate node-names for use with qemu [pkrempa] qemu: block: Format cache modes for disk storage backends [pkrempa] qemu: block: Format 'read-only' attribute for JSON disk protocol [pkrempa] qemu: block: Always set discard for storage nodes [pkrempa] qemu: block: Add support for creating 'format' layer for blockdev-add [pkrempa] tests: qemublock: Rename variables in anticipation of new tests [pkrempa] tests: Makefile: Sanitize entry for qemublocktest [pkrempa] qemu: domain: Export qemuDomainDeviceDefValidateDisk [pkrempa] qemu: domain: Tolerate NULL 'cfg' in qemuDomainPrepareDiskSourceChain [pkrempa] tests: qemublock: Add testing of blockdev JSON property generator [pkrempa] tests: qemublock: Add basic 'raw' file test [pkrempa] tests: qemublock: Add tests for all other format without special options [pkrempa] tests: qemublock: Add tests for basic backing chain formats [pkrempa] tests: qemublock: Add test-case for the 'vvfat' driver in qemu [pkrempa] tests: qemublock: Add test cases for 'aio' options of 'file' storage [pkrempa] tests: qemublock: Add test for raw luks disk format [pkrempa] tests: qemublock: basic qcow2 tests [pkrempa] tests: qemublock: Add test combining authentication and encryption [pkrempa] tests: qemublock: Test handling of 'unmap' and 'detect-zeroes' options [pkrempa] tests: qemublock: Test handling of all cache modes [pkrempa] tests: qemublock: Test handling of block devices ------------------------------------------ [...truncated 128.36 KB...] CC mktime.lo CC msvc-inval.lo CC msvc-nothrow.lo CC nl_langinfo.lo CC open.lo CC openpty.lo CC perror.lo CC pipe.lo CC poll.lo CC posix_openpt.lo ../../../gnulib/lib/poll.c: In function 'poll': ../../../gnulib/lib/poll.c:515:39: warning: passing argument 5 of 'select' from incompatible pointer type [-Wincompatible-pointer-types] if (select (0, &rfds, &wfds, &xfds, &tv0) > 0) ^ In file included from ../../../gnulib/lib/poll.c:39:0: /usr/x86_64-w64-mingw32/sys-root/mingw/include/winsock2.h:995:34: note: expected 'PTIMEVAL {aka struct timeval * const}' but argument is of type 'struct rpl_timeval *' WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set *readfds,fd_set *writefds,fd_set *exceptfds,const PTIMEVAL timeout); ^~~~~~ ../../../gnulib/lib/poll.c:551:37: warning: passing argument 5 of 'select' from incompatible pointer type [-Wincompatible-pointer-types] select (0, &rfds, &wfds, &xfds, &tv0); ^ In file included from ../../../gnulib/lib/poll.c:39:0: /usr/x86_64-w64-mingw32/sys-root/mingw/include/winsock2.h:995:34: note: expected 'PTIMEVAL {aka struct timeval * const}' but argument is of type 'struct rpl_timeval *' WINSOCK_API_LINKAGE int WSAAPI select(int nfds,fd_set *readfds,fd_set *writefds,fd_set *exceptfds,const PTIMEVAL timeout); ^~~~~~ CC printf-args.lo CC printf-parse.lo CC pthread_sigmask.lo CC raise.lo CC random_r.lo CC rawmemchr.lo CC readlink.lo CC realloc.lo CC recv.lo CC regex.lo CC secure_getenv.lo CC select.lo CC send.lo CC setenv.lo CC setsockopt.lo CC sigaction.lo CC sigprocmask.lo CC sleep.lo CC snprintf.lo CC socket.lo CC stat.lo CC stat-w32.lo CC stdio-read.lo CC stdio-write.lo CC stpcpy.lo CC strchrnul.lo CC strdup.lo CC strerror.lo CC strerror-override.lo CC strerror_r.lo CC strndup.lo CC strptime.lo CC strsep.lo CC time_r.lo CC timegm.lo CC ttyname_r.lo CC uname.lo CC unsetenv.lo CC usleep.lo CC vasnprintf.lo CC vsnprintf.lo CC waitpid.lo GEN charset.alias GEN ref-add.sed GEN ref-del.sed CC glthread/lock.lo CCLD libgnu.la gmake[3]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/gnulib/lib'> gmake[2]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/gnulib/lib'> Making all in include/libvirt gmake[2]: Entering directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/include/libvirt'> gmake[2]: Nothing to be done for 'all'. gmake[2]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/include/libvirt'> Making all in src gmake[2]: Entering directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/src'> GEN util/virkeycodetable_linux.h GEN util/virkeycodetable_osx.h GEN util/virkeycodetable_atset1.h GEN util/virkeycodetable_atset2.h GEN util/virkeycodetable_atset3.h GEN util/virkeycodetable_xtkbd.h GEN util/virkeycodetable_win32.h GEN util/virkeycodetable_usb.h GEN util/virkeycodetable_qnum.h GEN util/virkeynametable_linux.h GEN util/virkeynametable_osx.h GEN util/virkeynametable_win32.h GEN ../../src/access/org.libvirt.api.policy GEN access/viraccessapicheck.h GEN access/viraccessapicheck.c GEN access/viraccessapicheckqemu.h GEN access/viraccessapicheckqemu.c GEN access/viraccessapichecklxc.h GEN access/viraccessapichecklxc.c GEN libvirt_access.xml GEN libvirt_access_qemu.xml GEN libvirt_access_lxc.xml GEN logging/log_protocol.h GEN logging/log_daemon_dispatch_stubs.h GEN locking/lock_protocol.h GEN locking/lock_daemon_dispatch_stubs.h GEN admin/admin_protocol.h GEN admin/admin_client.h GEN admin/admin_server_dispatch_stubs.h GEN rpc/virnetprotocol.h GEN rpc/virkeepaliveprotocol.h GEN .esx_vi_generator.stamp GEN .hyperv_wmi_generator.stamp GEN lxc/lxc_monitor_protocol.h GEN lxc/lxc_monitor_dispatch.h GEN ../../src/hyperv/hyperv_wmi_classes.generated.typedef GEN ../../src/hyperv/hyperv_wmi_classes.generated.h GEN ../../src/hyperv/hyperv_wmi_classes.generated.c GEN lxc/lxc_controller_dispatch.h GEN ../../src/esx/esx_vi_types.generated.typedef GEN ../../src/esx/esx_vi_types.generated.typeenum GEN ../../src/esx/esx_vi_types.generated.typetostring GEN ../../src/esx/esx_vi_types.generated.typefromstring GEN ../../src/esx/esx_vi_types.generated.h GEN ../../src/esx/esx_vi_types.generated.c GEN ../../src/esx/esx_vi_methods.generated.h GEN ../../src/esx/esx_vi_methods.generated.c GEN ../../src/esx/esx_vi_methods.generated.macro GEN ../../src/esx/esx_vi.generated.h GEN ../../src/esx/esx_vi.generated.c GEN remote/remote_protocol.h GEN remote/remote_client_bodies.h GEN remote/lxc_protocol.h GEN remote/lxc_client_bodies.h GEN remote/qemu_protocol.h GEN remote/qemu_client_bodies.h GEN remote/remote_daemon_dispatch_stubs.h GEN remote/remote_daemon_dispatch_lxc_stubs.h GEN remote/remote_daemon_dispatch_qemu_stubs.h GEN libvirt_access.syms GEN libvirt_access_qemu.syms GEN libvirt_access_lxc.syms GEN libvirt_qemu.def GEN libvirt_lxc.def GEN libvirt_admin.syms GEN libvirtd.qemu.logrotate GEN libvirtd.lxc.logrotate GEN libvirtd.libxl.logrotate GEN libvirtd.uml.logrotate GEN libvirtd.logrotate GEN logging/log_protocol.c GEN locking/lock_protocol.c GEN admin/admin_protocol.c GEN rpc/virnetprotocol.c GEN rpc/virkeepaliveprotocol.c GEN lxc/lxc_monitor_protocol.c GEN remote/remote_protocol.c GEN remote/lxc_protocol.c GEN remote/qemu_protocol.c GEN libvirt.syms GEN libvirt_admin.def GEN libvirt.def /usr/bin/gmake all-am gmake[3]: Entering directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/src'> CC libvirt_driver_la-driver.lo CC libvirt_driver_la-datatypes.lo CC libvirt_driver_la-libvirt.lo CC libvirt_driver_la-libvirt-domain.lo CC libvirt_driver_la-libvirt-domain-snapshot.lo CC libvirt_driver_la-libvirt-host.lo CC libvirt_driver_la-libvirt-interface.lo CC libvirt_driver_la-libvirt-network.lo CC libvirt_driver_la-libvirt-nodedev.lo CC libvirt_driver_la-libvirt-nwfilter.lo CC libvirt_driver_la-libvirt-secret.lo CC libvirt_driver_la-libvirt-storage.lo CC libvirt_driver_la-libvirt-stream.lo CC libvirt_qemu_la-libvirt-qemu.lo CC libvirt_lxc_la-libvirt-lxc.lo CC libvirt_admin_la-libvirt-admin.lo CC libvirt_admin_la-datatypes.lo CC admin/libvirt_driver_admin_la-admin_protocol.lo CC admin/libvirt_driver_admin_la-admin_server.lo CC admin/libvirt_driver_admin_la-admin_server_dispatch.lo GEN util/virkeycode-linux.pod GEN util/virkeycode-osx.pod GEN util/virkeycode-atset1.pod GEN util/virkeycode-atset2.pod GEN util/virkeycode-atset3.pod GEN util/virkeycode-xtkbd.pod GEN util/virkeycode-usb.pod GEN util/virkeycode-win32.pod GEN util/virkeycode-qnum.pod GEN util/virkeyname-linux.pod GEN util/virkeyname-osx.pod GEN util/virkeyname-win32.pod CC util/libvirt_util_la-viralloc.lo CC util/libvirt_util_la-virarch.lo CC util/libvirt_util_la-virarptable.lo CC util/libvirt_util_la-viratomic.lo CC util/libvirt_util_la-viraudit.lo CC util/libvirt_util_la-virauth.lo CC util/libvirt_util_la-virauthconfig.lo CC util/libvirt_util_la-virbitmap.lo CC util/libvirt_util_la-virbuffer.lo CC util/libvirt_util_la-virperf.lo CC util/libvirt_util_la-vircgroup.lo CC util/libvirt_util_la-virclosecallbacks.lo CC util/libvirt_util_la-vircommand.lo CC util/libvirt_util_la-virconf.lo CC util/libvirt_util_la-vircrypto.lo CC util/libvirt_util_la-virdbus.lo CC util/libvirt_util_la-virdevmapper.lo CC util/libvirt_util_la-virdnsmasq.lo CC util/libvirt_util_la-virebtables.lo CC util/libvirt_util_la-virerror.lo CC util/libvirt_util_la-virevent.lo CC util/libvirt_util_la-vireventpoll.lo CC util/libvirt_util_la-virfcp.lo CC util/libvirt_util_la-virfdstream.lo CC util/libvirt_util_la-virfile.lo CC util/libvirt_util_la-virfirewall.lo CC util/libvirt_util_la-virfirmware.lo CC util/libvirt_util_la-virgettext.lo ../../src/util/virfile.c: In function 'virFileIsCDROM': ../../src/util/virfile.c:1985:40: error: macro "STRPREFIX" passed 3 arguments, but takes just 2 if (STRPREFIX(path, "/dev/cd", NULL) || ^ ../../src/util/virfile.c:1985:9: error: 'STRPREFIX' undeclared (first use in this function) if (STRPREFIX(path, "/dev/cd", NULL) || ^~~~~~~~~ ../../src/util/virfile.c:1985:9: note: each undeclared identifier is reported only once for each function it appears in ../../src/util/virfile.c:1986:41: error: macro "STRPREFIX" passed 3 arguments, but takes just 2 STRPREFIX(path, "/dev/acd", NULL)) ^ ../../src/util/virfile.c:1983:28: error: unused parameter 'path' [-Werror=unused-parameter] virFileIsCDROM(const char *path) ^~~~ cc1: all warnings being treated as errors gmake[3]: *** [Makefile:11458: util/libvirt_util_la-virfile.lo] Error 1 gmake[3]: *** Waiting for unfinished jobs.... rm util/virkeycode-xtkbd.pod util/virkeycode-atset3.pod util/virkeycode-usb.pod util/virkeycode-qnum.pod util/virkeycode-win32.pod util/virkeyname-linux.pod util/virkeycode-osx.pod util/virkeycode-linux.pod util/virkeyname-osx.pod util/virkeycode-atset1.pod util/virkeyname-win32.pod util/virkeycode-atset2.pod gmake[3]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/src'> gmake[2]: *** [Makefile:6881: all] Error 2 gmake[2]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build/src'> gmake[1]: *** [Makefile:2105: all-recursive] Error 1 gmake[1]: Leaving directory '<https://ci.centos.org/job/libvirt-master-build-mingw64/systems=libvirt-fedora-rawhide/ws/build'> gmake: *** [Makefile:1998: all] Error 2 Build step 'Execute shell' marked build as failure