9:13 p.m.
Build Update for libvirt/libvirt
-------------------------------------
Build: #2503
Status: Passed
Duration: 38 mins and 3 secs
Commit: fed58d8 (master)
Author: Eric Blake
Message: build: Fix checkpoint_conf on mingw
CI flagged a failing mingw build, due to:
In file included from ../../src/conf/checkpoint_conf.c:24:
../gnulib/lib/configmake.h:8:17: error: expected identifier or '(' before string
constant
8 | #define DATADIR "/usr/i686-w64-mingw32/sys-root/mingw/share"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
As previously learned in commits bd205a90 and 976abdf6, gnulib's
configmake.h header does #define DATADIR "string...", while mingw's
<winsock2.h> expects to declare a type named DATADIR. As long as the
mingw system header is included first before configmake.h, the two
uses do not conflict, but until gnulib is patched to make configmake.h
automatically work around the issue, our immediate fix is the
workaround of rearranging our include order to insure no conflict.
Copy the paradigm used in domain_conf.c of using <unistd.h> to trigger
the indirect inclusion of <winsock2.h> on mingw.
Fixes: 1a4df34a
Signed-off-by: Eric Blake <eblake(a)redhat.com>
View the changeset:
https://github.com/libvirt/libvirt/compare/a1be4aaa96f1...fed58d83c60f
View the full build log and details:
https://travis-ci.org/libvirt/libvirt/builds/565109091?utm_medium=notific...
--
You can unsubscribe from build emails from the libvirt/libvirt repository going to
https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&....
Or unsubscribe from *all* email updating your settings at
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notifica....
Or configure specific recipients for build notifications in your .travis.yml file. See
https://docs.travis-ci.com/user/notifications.