10:47 p.m.
Build Update for libvirt/libvirt
-------------------------------------
Build: #3446
Status: Passed
Duration: 25 mins and 23 secs
Commit: 55029d9 (v6.4.0-rc1)
Author: Christian Ehrhardt
Message: security: don't fail if built without attr support
If built without attr support removing any image will trigger
qemuBlockRemoveImageMetadata (the one that emits the warning)
-> qemuSecurityMoveImageMetadata
-> virSecurityManagerMoveImageMetadata
-> virSecurityDACMoveImageMetadata
-> virSecurityDACMoveImageMetadataHelper
-> virProcessRunInFork (spawns subprocess)
-> virSecurityMoveRememberedLabel
In there due to !HAVE_LIBATTR virFileGetXAttrQuiet will return
ENOSYS and from there the chain will error out.
That is wrong and looks like:
libvirtd[6320]: internal error: child reported (status=125):
libvirtd[6320]: Unable to remove disk metadata on vm testguest from
/var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda)
This change makes virSecurityDACMoveImageMetadataHelper and
virSecuritySELinuxMoveImageMetadataHelper accept that
error code gracefully and in that sense it is an extension of:
5214b2f1a3f "security: Don't skip label restore on file systems lacking
XATTRs"
which does the same for other call chains into the virFile*XAttr functions.
Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com>
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
View the changeset: https://github.com/libvirt/libvirt/compare/v6.4.0-rc1
View the full build log and details:
https://travis-ci.org/github/libvirt/libvirt/builds/691901807?utm_medium=...
--
You can unsubscribe from build emails from the libvirt/libvirt repository going to
https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&....
Or unsubscribe from *all* email updating your settings at
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notifica....
Or configure specific recipients for build notifications in your .travis.yml file. See
https://docs.travis-ci.com/user/notifications.