New Defects Reported

Hi,

Please find the latest report on new defect(s) introduced to libvirt found with Coverity Scan.

New Defects Found: 3
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
Defects Shown: Showing 3 of 3 defect(s)

Defect Details

** CID 913365:       Insecure data handling  (TAINTED_STRING)


_____________________________________________________________________________________________
*** CID 913365:         Insecure data handling  (TAINTED_STRING)
/tests/nwfilternftablestest.c: 426             in main()
420                        NULL) < 0)
421             ret = -1;
422     
423         return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
424     }
425     
>>>     CID 913365:         Insecure data handling  (TAINTED_STRING)
>>>     Passing tainted string "**argv" to "virTestMain", which cannot accept tainted data.

** CID 913364:       Insecure data handling  (TAINTED_STRING)


_____________________________________________________________________________________________
*** CID 913364:         Insecure data handling  (TAINTED_STRING)
/tests/nwfilterxml2nftfirewalltest.c: 423             in main()
417         DO_TEST("udplite-ipv6");
418         DO_TEST("vlan");
419     
420         return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
421     }
422     
>>>     CID 913364:         Insecure data handling  (TAINTED_STRING)
>>>     Passing tainted string "**argv" to "virTestMain", which cannot accept tainted data.
423     VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virfirewall"))
424     
425     #else /* ! defined (__linux__) */
426     
427     int main(void)
428     {
429         return EXIT_AM_SKIP;
430     }
431     

** CID 913363:       Null pointer dereferences  (NULL_RETURNS)
/src/nwfilter/nwfilter_nftables_driver.c: 2390           in nftablesHandleRemoveAll()


_____________________________________________________________________________________________
*** CID 913363:         Null pointer dereferences  (NULL_RETURNS)
/src/nwfilter/nwfilter_nftables_driver.c: 2390             in nftablesHandleRemoveAll()
2384             virSkipSpaces(&line);
2385     
2386             /* delete tmp jumps */
2387             if (strstr(line, fwCompare) != NULL ||
2388                 strstr(line, tmpFwCompare) != NULL) {
2389                 line = strchr(line, '#');
>>>     CID 913363:         Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "line" when calling "strncmp".
2390                 if ((line = STRSKIP(line, "# handle ")) == NULL)
2391                     continue;
2392     
2393                 /* delete tmp jump */
2394                 virFirewallAddCmd(fw, layer,
2395                                   "delete", "rule", "bridge", tableName, chain,

View Defects in Coverity Scan

Best regards,

The Coverity Scan Admin Team