5:05 p.m.
Build Update for libvirt/libvirt
-------------------------------------
Build: #3192
Status: Broken
Duration: 31 mins and 4 secs
Commit: 09352cc (master)
Author: Peter Krempa
Message: VIR_FREE: Replace internals by g_clear_pointer
Our implementation masks GCC warnings of uninitialized use of the passed
argument. After changing this I got a load of following warnings:
src/conf/virnetworkportdef.c: In function 'virNetworkPortDefSaveStatus':
/usr/include/glib-2.0/glib/gmem.h:136:8: error: 'path' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
136 | if (_p) \
| ^
src/conf/virnetworkportdef.c:447:11: note: 'path' was declared here
447 | char *path;
| ^~~~
For the curious, g_clear_pointer is still safe for arguments with
side-effect. Here's the pre-processed output of trying to do a
VIR_FREE(*(test2++)):
do {
typedef char _GStaticAssertCompileTimeAssertion_1[(sizeof *(&(*(test2++))) ==
sizeof (gpointer)) ? 1 : -1] __attribute__((__unused__));
__typeof__((&(*(test2++)))) _pp = (&(*(test2++)));
__typeof__(*(&(*(test2++)))) _ptr = *_pp;
*_pp = ((void *)0);
if (_ptr)
(g_free) (_ptr);
} while (0) ;
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
View the changeset:
https://github.com/libvirt/libvirt/compare/5bff668dfb21...09352cca2a56
View the full build log and details:
https://travis-ci.org/libvirt/libvirt/builds/658740381?utm_medium=notific...
--
You can unsubscribe from build emails from the libvirt/libvirt repository going to
https://travis-ci.org/account/preferences/unsubscribe?repository=4872032&....
Or unsubscribe from *all* email updating your settings at
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notifica....
Or configure specific recipients for build notifications in your .travis.yml file. See
https://docs.travis-ci.com/user/notifications.