Hi,

Please find the latest report on new defect(s) introduced to libvirt-dbus found with Coverity Scan.

• New Defects Found: 4
• 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
• Defects Shown: Showing 4 of 4 defect(s)

Defect Details

** CID 1653363:       Program hangs  (LOCK)
/src/domain.c: 3060           in virtDBusDomainSnapshotCurrent()


_____________________________________________________________________________________________
*** CID 1653363:         Program hangs  (LOCK)
/src/domain.c: 3060             in virtDBusDomainSnapshotCurrent()
3054         g_variant_get(inArgs, "(u)", &flags);
3055     
3056         domain = virtDBusDomainGetVirDomain(connect, objectPath, error);
3057         if (!domain)
3058             return;
3059     
>>>     CID 1653363:         Program hangs  (LOCK)
>>>     "virtDBusConnectOpen" locks "connect->lock" while it is locked.
3060         if (!virtDBusConnectOpen(connect, error))
3061             return;
3062     
3063         snapshot = virDomainSnapshotCurrent(domain, flags);
3064         if (!snapshot)
3065             return virtDBusUtilSetLastVirtError(error);

** CID 1653362:       Program hangs  (LOCK)
/src/domain.c: 1882           in virtDBusDomainListDomainSnapshots()


_____________________________________________________________________________________________
*** CID 1653362:         Program hangs  (LOCK)
/src/domain.c: 1882             in virtDBusDomainListDomainSnapshots()
1876         g_variant_get(inArgs, "(u)", &flags);
1877     
1878         domain = virtDBusDomainGetVirDomain(connect, objectPath, error);
1879         if (!domain)
1880             return;
1881     
>>>     CID 1653362:         Program hangs  (LOCK)
>>>     "virtDBusConnectOpen" locks "connect->lock" while it is locked.
1882         if (!virtDBusConnectOpen(connect, error))
1883             return;
1884     
1885         if (virDomainListAllSnapshots(domain, &domainSnapshots, flags) < 0)
1886             return virtDBusUtilSetLastVirtError(error);
1887     

** CID 1653361:       Program hangs  (LOCK)
/src/domain.c: 3132           in virtDBusDomainSnapshotLookupByName()


_____________________________________________________________________________________________
*** CID 1653361:         Program hangs  (LOCK)
/src/domain.c: 3132             in virtDBusDomainSnapshotLookupByName()
3126         g_variant_get(inArgs, "(&su)", &name, &flags);
3127     
3128         domain = virtDBusDomainGetVirDomain(connect, objectPath, error);
3129         if (!domain)
3130             return;
3131     
>>>     CID 1653361:         Program hangs  (LOCK)
>>>     "virtDBusConnectOpen" locks "connect->lock" while it is locked.
3132         if (!virtDBusConnectOpen(connect, error))
3133             return;
3134     
3135         snapshot = virDomainSnapshotLookupByName(domain, name, flags);
3136         if (!snapshot)
3137             return virtDBusUtilSetLastVirtError(error);

** CID 1653360:       Program hangs  (LOCK)
/src/domain.c: 3096           in virtDBusDomainSnapshotCreateXML()


_____________________________________________________________________________________________
*** CID 1653360:         Program hangs  (LOCK)
/src/domain.c: 3096             in virtDBusDomainSnapshotCreateXML()
3090         g_variant_get(inArgs, "(&su)", &xml, &flags);
3091     
3092         domain = virtDBusDomainGetVirDomain(connect, objectPath, error);
3093         if (!domain)
3094             return;
3095     
>>>     CID 1653360:         Program hangs  (LOCK)
>>>     "virtDBusConnectOpen" locks "connect->lock" while it is locked.
3096         if (!virtDBusConnectOpen(connect, error))
3097             return;
3098     
3099         snapshot = virDomainSnapshotCreateXML(domain, xml, flags);
3100         if (!snapshot)
3101             return virtDBusUtilSetLastVirtError(error);

  

View Defects in Coverity Scan

Best regards,

The Coverity Scan Admin Team